Skip to content

added logger through config file#18

Open
Paola351 wants to merge 4 commits intoerror401de:mainfrom
Paola351:logger_file
Open

added logger through config file#18
Paola351 wants to merge 4 commits intoerror401de:mainfrom
Paola351:logger_file

Conversation

@Paola351
Copy link
Contributor

No description provided.

@Paola351 Paola351 mentioned this pull request Oct 10, 2020
@Paola351
Copy link
Contributor Author

Paola351 commented Oct 11, 2020

@error401de when i pushed the code everything was alright, I promise 😁 (I read again the FAQ of the hacktoberfest and only the pullrequest labeled are accepted)

…into logger_file

� Conflicts:
�	checkTasks.py
@Paola351
Copy link
Contributor Author

Paola351 commented Oct 11, 2020

@error401de I merged the branch again so there are no conflict :D

@error401de
Copy link
Owner

@Paola351 If you look at the diff at https://github.com/error401de/recurring-tasks/pull/18/files you can see that e.g. line 8 would overwrite changes that has been made yesterday, so something is wrong with your rebasing.

As you can see due to the insertion of the try except block, Github can't show the differences nicely anymore. Thats due to the fact that github diffs simply line-based.
Plus I saw that the new ini file doesn't follow the styling like the other ones (space before and after '=')

So overall: Line 8 needs to be changed in any case. For the rest I need some time to check it as the diff-issue doesn't let me do it easily. I'm not sure if i will be able to do that today.

You already did a lot, so I will give you the hacktoberfest-accepted label right away, merging of this PR might take some time.

@Paola351
Copy link
Contributor Author

@Paola351 If you look at the diff at https://github.com/error401de/recurring-tasks/pull/18/files you can see that e.g. line 8 would overwrite changes that has been made yesterday, so something is wrong with your rebasing.

As you can see due to the insertion of the try except block, Github can't show the differences nicely anymore. Thats due to the fact that github diffs simply line-based.
Plus I saw that the new ini file doesn't follow the styling like the other ones (space before and after '=')

So overall: Line 8 needs to be changed in any case. For the rest I need some time to check it as the diff-issue doesn't let me do it easily. I'm not sure if i will be able to do that today.

You already did a lot, so I will give you the hacktoberfest-accepted label right away, merging of this PR might take some time.

You're right! Totally forgot that string! As there were so many conflicts, it took some time to solve them all and I forgot to check that part. I'm solving that right away:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants