fix(web): display slash command args in message view #55
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| <script module> | ||
| import { defineMeta } from '@storybook/addon-svelte-csf' | ||
| import MessageItem from './MessageItem.svelte' | ||
|
|
||
| const noop = () => {} | ||
|
|
||
| const { Story } = defineMeta({ | ||
| title: 'Components/MessageItem', | ||
| component: MessageItem, | ||
| tags: ['autodocs'], | ||
| args: { | ||
| sessionId: 'test-session', | ||
| onDelete: noop, | ||
| }, | ||
| }) | ||
| </script> | ||
|
|
||
| <Story | ||
| name="Slash Command Without Args" | ||
| args={{ | ||
| msg: { | ||
| uuid: 'msg-1', | ||
| type: 'human', | ||
| timestamp: new Date().toISOString(), | ||
| message: { content: '<command-name>/vsix</command-name>' }, | ||
| }, | ||
| }} | ||
| > | ||
| {#snippet children(args)} | ||
| <div class="p-4 bg-gh-canvas text-gh-text max-w-2xl"> | ||
| <MessageItem {...args} /> | ||
| </div> | ||
| {/snippet} | ||
| </Story> | ||
|
|
||
| <Story | ||
| name="Slash Command With Args" | ||
| args={{ | ||
| msg: { | ||
| uuid: 'msg-2', | ||
| type: 'human', | ||
| timestamp: new Date().toISOString(), | ||
| message: { | ||
| content: | ||
| '<command-name>/session</command-name>\n<command-args>repair --dry-run e15f9f9a</command-args>', | ||
| }, | ||
| }, | ||
| }} | ||
| > | ||
| {#snippet children(args)} | ||
| <div class="p-4 bg-gh-canvas text-gh-text max-w-2xl"> | ||
| <MessageItem {...args} /> | ||
| </div> | ||
| {/snippet} | ||
| </Story> | ||
|
|
||
| <Story | ||
| name="Slash Command With Short Args" | ||
| args={{ | ||
| msg: { | ||
| uuid: 'msg-3', | ||
| type: 'human', | ||
| timestamp: new Date().toISOString(), | ||
| message: { | ||
| content: '<command-name>/skill-name</command-name>\n<command-args>topic</command-args>', | ||
| }, | ||
| }, | ||
| }} | ||
| > | ||
| {#snippet children(args)} | ||
| <div class="p-4 bg-gh-canvas text-gh-text max-w-2xl"> | ||
| <MessageItem {...args} /> | ||
| </div> | ||
| {/snippet} | ||
| </Story> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,6 +162,35 @@ | |
| }, | ||
| ] | ||
|
|
||
| // Slash command with args | ||
| const slashCommandMessages = [ | ||
| { | ||
| type: 'human', | ||
| uuid: 'cmd-1', | ||
| parentUuid: null, | ||
| timestamp: '2026-01-20T10:00:00.000Z', | ||
| message: { | ||
| content: | ||
| '<command-name>/session</command-name>\n<command-args>repair --dry-run e15f9f9a</command-args>', | ||
| }, | ||
| }, | ||
| { | ||
| type: 'assistant', | ||
| uuid: 'cmd-2', | ||
| parentUuid: 'cmd-1', | ||
| timestamp: '2026-01-20T10:00:05.000Z', | ||
| message: { | ||
| role: 'assistant', | ||
| content: [ | ||
| { | ||
| type: 'text', | ||
| text: 'Running session repair in dry-run mode for e15f9f9a...\n\nNo issues found. The session chain is intact.', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ] | ||
|
|
||
| // Empty messages | ||
| const emptyMessages = [] | ||
|
|
||
|
|
@@ -236,6 +265,22 @@ | |
| {/snippet} | ||
| </Story> | ||
|
|
||
| <Story | ||
| name="Slash Command With Args" | ||
| args={{ | ||
| sessionId: mockSessionId, | ||
| messages: slashCommandMessages, | ||
| onDeleteMessage: handleDelete, | ||
| onSplitSession: handleSplit, | ||
| }} | ||
| > | ||
| {#snippet children(args)} | ||
| <div class="max-w-4xl"> | ||
| <MessageList {...args} /> | ||
| </div> | ||
| {/snippet} | ||
| </Story> | ||
|
|
||
| <Story | ||
| name="Empty Messages" | ||
| args={{ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fixed timestamps in stories to keep snapshots deterministic.
Using
new Date().toISOString()introduces run-to-run UI diffs in Storybook visual regression flows. Prefer a static timestamp.💡 Proposed fix
<script module> import { defineMeta } from '@storybook/addon-svelte-csf' import MessageItem from './MessageItem.svelte' const noop = () => {} + const fixedTimestamp = '2026-01-20T10:00:00.000Z' @@ uuid: 'msg-1', type: 'human', - timestamp: new Date().toISOString(), + timestamp: fixedTimestamp, @@ uuid: 'msg-2', type: 'human', - timestamp: new Date().toISOString(), + timestamp: fixedTimestamp, @@ uuid: 'msg-3', type: 'human', - timestamp: new Date().toISOString(), + timestamp: fixedTimestamp,Also applies to: 42-42, 63-63
🤖 Prompt for AI Agents