grid_integrator: Allow passing custom arguments to integrand function.#188
Open
corepattern wants to merge 4 commits intoesa:developfrom
Open
grid_integrator: Allow passing custom arguments to integrand function.#188corepattern wants to merge 4 commits intoesa:developfrom
corepattern wants to merge 4 commits intoesa:developfrom
Conversation
release -> main (for v0.4.0)
This is to avoid invoking a lambda wrapper function just expose an already existing functionality.
Collaborator
|
@corepattern Thanks for the PR! I have fixed the things leading to errors in the CI in #191 . Could you try merging that branch? And also kindly run I will also take the liberty of changing the base as this should go into develop not main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows avoiding the invocation of a lambda wrapper function.
The commit just exposes an already existing functionality.
Also related to #187