fix(release): composer install before zip so central locales ship#52
Merged
fix(release): composer install before zip so central locales ship#52
Conversation
The plugin's textdomain loader reads from
vendor/escalated-dev/locale/languages/escalated-{locale}.mo (introduced
in #51 / cfc9c81). The release workflow built the zip from a fresh
checkout without running composer install, so vendor/ was empty and the
zip silently shipped without central translations — the plugin's
fallback to the legacy in-tree languages/ dir hid the regression at
runtime, but downstream installs miss portfolio-wide updates.
Add a setup-php + composer install step before the rsync. composer.json
itself stays excluded from the zip (end-users don't need it); only the
resolved vendor/ tree is bundled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Spotted by @MatthewPG while reviewing #51 (cfc9c81). The plugin's textdomain loader reads central translations from
vendor/escalated-dev/locale/languages/escalated-{locale}.mo, but the release workflow builds the zip from a fresh checkout without runningcomposer install— sovendor/is empty and the zip silently ships without central translations.The plugin's fallback to the legacy in-tree
languages/dir hid the regression at runtime, but downstream installs miss portfolio-wide locale updates.Fix
Add
shivammathur/setup-php@v2+composer install --no-dev --no-interaction --prefer-dist --optimize-autoloaderbefore the rsync. composer.json itself stays excluded from the zip (end-users don't need it); only the resolvedvendor/tree is bundled.Verification
After merge, tag a v* release and confirm the asset on the GitHub Release contains
escalated/vendor/escalated-dev/locale/languages/escalated-en_US.mo(and other locales).