add support for regions and subDomain buckets#10
Open
sytabaresa wants to merge 1 commit intoeschultink:masterfrom
Open
add support for regions and subDomain buckets#10sytabaresa wants to merge 1 commit intoeschultink:masterfrom
sytabaresa wants to merge 1 commit intoeschultink:masterfrom
Conversation
watch-dog-mm
approved these changes
Nov 9, 2022
|
@eschultink @sytabaresa LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!, I see that this project is so awesome, but lacks different region aport of 'us-east-1' and the use of subdomain like bucket (the buckets that you can create with dots between and you can access with that custom domain using DNS/CDN proxy) so I change some little thing to add support to that
let me know if that changes are valuable to merge in.
Sincerely
Sebastian Tabares