Skip to content

Kafka fix #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kataevandrey merged 2 commits into from
Mar 31, 2026
Merged

Kafka fix #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f71f22
fix: kafka docker container creation fix
somepoi Mar 8, 2026
25b034d
validation that key_str contains only digits
somepoi Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/moderationservice/kafka/kafkaclient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,16 @@ void KafkaConsumer::ProcessMessage(RdKafka::Message* message) {

std::string key_str(key_ptr, message->key_len());

// Validate that key_str contains only digits (and optional leading +/-)
if (key_str.empty() || (!std::isdigit(key_str[0]) && key_str[0] != '-' && key_str[0] != '+')) {
std::cerr << "Invalid message key format (not numeric): '" << key_str << "'\n";
return;
}

try {
request_id = std::stoll(key_str);
} catch (const std::exception& e) {
std::cerr << "Failed to parse message key to request ID: " << e.what() << "\n";
std::cerr << "Failed to parse message key '" << key_str << "' to request ID: " << e.what() << "\n";
return;
}
}
Expand Down
4 changes: 2 additions & 2 deletions tools/common.just
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ build-windows: fetch-proto

kafka-container-up:
docker-compose up -d
MSYS_NO_PATHCONV=1 docker exec kafka /opt/kafka/bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic moderation-result --replication-factor 1 --partitions 3
MSYS_NO_PATHCONV=1 docker exec kafka /opt/kafka/bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic moderation-request --replication-factor 1 --partitions 3
MSYS_NO_PATHCONV=1 docker exec kafka /opt/kafka/bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic moderation-result --replication-factor 1 --partitions 3 || true
MSYS_NO_PATHCONV=1 docker exec kafka /opt/kafka/bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic moderation-request --replication-factor 1 --partitions 3 || true

kafka-container-down:
MSYS_NO_PATHCONV=1 docker exec kafka /opt/kafka/bin/kafka-topics.sh --bootstrap-server localhost:9092 --delete --topic moderation-request
Expand Down
Loading