Skip to content

Suppress Wails non-file drag rejection / 抑制 Wails 非文件拖拽误报#4450

Merged
SivanCola merged 3 commits into
main-v2from
fix/suppress-wails-drag-rejection
Jun 16, 2026
Merged

Suppress Wails non-file drag rejection / 抑制 Wails 非文件拖拽误报#4450
SivanCola merged 3 commits into
main-v2from
fix/suppress-wails-drag-rejection

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Suppress the known Wails non-file drag rejection when WebView reports invalid argument immediately after a native file drag.
  • Keep generic invalid argument errors visible outside that drag context.
  • Add regression coverage and wire it into the desktop frontend test scripts.

Verification

  • cd desktop && wails generate module
  • pnpm --dir desktop/frontend test:typecheck
  • pnpm --dir desktop/frontend test
  • pnpm --dir desktop/frontend build

@SivanCola SivanCola requested a review from esengine as a code owner June 15, 2026 06:06
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d6ac504a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/frontend/src/lib/bridge.ts Outdated
Comment thread desktop/frontend/src/lib/bridge.ts Outdated
@SivanCola SivanCola enabled auto-merge June 15, 2026 06:18
@SivanCola SivanCola disabled auto-merge June 16, 2026 04:06
@SivanCola SivanCola merged commit ca66d37 into main-v2 Jun 16, 2026
13 checks passed
@SivanCola SivanCola deleted the fix/suppress-wails-drag-rejection branch June 16, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant