Require approval for awk and sed bash commands / 要求 awk 和 sed Bash 命令审批#4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awkandsedbash commands as approval-required instead of read-only.awk system(),awkfile writes, andsed ecommand execution.Problem
The bash read-only classifier allowed
awkandsedbased only on the command name. Those tools can execute shell commands or write files from inside their scripts, so classifying them as read-only could bypass Ask-mode approval.Verification
go test ./internal/permission ./internal/agent -count=1go test ./internal/sandbox ./internal/tool/builtin -run 'TestSandboxEnforcesWrites|TestBashSandboxConfinement' -count=1