Skip to content

Keep new tab button beside tabs / 固定新建会话按钮贴近标签页#4493

Merged
esengine merged 1 commit into
esengine:main-v2from
SivanCola:fix/tabbar-new-button-position
Jun 16, 2026
Merged

Keep new tab button beside tabs / 固定新建会话按钮贴近标签页#4493
esengine merged 1 commit into
esengine:main-v2from
SivanCola:fix/tabbar-new-button-position

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the themed desktop tab list sized to its tab content before it shrinks.
  • Preserve a stable new-session button slot immediately after the last visible tab.
  • Add AppChrome CSS contract coverage so the themed tab list cannot grow into empty chrome space again.

Root cause

The themed AppChrome tab list used flex: 1 1 auto, so it expanded across the remaining titlebar space and pushed the + new-session button toward the right chrome controls when the right dock changed the available width.

Verification

  • npm run check:css
  • tsx src/__tests__/app-chrome-tabs.test.ts
  • Browser DOM check confirmed the tab list no longer flex-grows and the + button sits beside the last tab.

Related

@SivanCola SivanCola requested a review from esengine as a code owner June 15, 2026 08:48
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) and removed v2 Go rewrite (1.x) — main-v2 branch, active development labels Jun 15, 2026
@SivanCola

Copy link
Copy Markdown
Collaborator Author

Supersession note: #3986 explored the alternate product direction of removing the duplicate top + new-session button. For the current UI direction, this PR keeps the top + affordance and fixes its placement instead.

Thank you @NkAntony777 for the work in #3986: it clarified the duplicate-entry concern and helped frame the final product decision here.

Authorship note: @SivanCola is the primary author of this PR. @NkAntony777 contributed as a repository collaborator through #3986; that contribution is acknowledged as part of the shared repository work behind this final tab/new-session direction.

@SivanCola SivanCola enabled auto-merge June 15, 2026 09:53
@esengine esengine merged commit 72844ee into esengine:main-v2 Jun 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 新建会话和搜索框会随着右边侧栏内容打开与合并进而发生位置变化,这个能固定住吗

2 participants