Skip to content

Fix desktop welcome clipping on fullscreen resize / 修复桌面端全屏后欢迎页裁剪#4503

Merged
esengine merged 2 commits into
esengine:main-v2from
SivanCola:fix/desktop-welcome-fullscreen-clipping
Jun 16, 2026
Merged

Fix desktop welcome clipping on fullscreen resize / 修复桌面端全屏后欢迎页裁剪#4503
esengine merged 2 commits into
esengine:main-v2from
SivanCola:fix/desktop-welcome-fullscreen-clipping

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Track the live viewport height so the desktop shell follows macOS fullscreen and resize updates.
  • Let the empty transcript scroll instead of clipping the welcome actions, and reset empty-state scroll position.
  • Keep the native window background synced with the active theme to avoid exposing a black shell during repaint gaps.

Fixes #4494

Verification

  • npm run check:css
  • npx tsx src/__tests__/typography-overflow-contract.test.ts
  • npm run build
  • Browser preview checked with ?platform=darwin&mock=fresh at normal and short viewport heights.

@SivanCola SivanCola requested a review from esengine as a code owner June 15, 2026 09:31
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b341780ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/frontend/src/styles.css
@SivanCola SivanCola enabled auto-merge June 15, 2026 09:52
@esengine esengine merged commit 4d193f2 into esengine:main-v2 Jun 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 全屏中间选项被遮盖

2 participants