Skip to content

fix(agent): add active-goal to transient user block regex (#4464) #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myipanta wants to merge 2 commits into
base: main-v2
Choose a base branch
from
+24 −1
Open

fix(agent): add active-goal to transient user block regex (#4464) #4513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25b946c
fix(agent): add active-goal to transient user block regex (#4464)
ipanta Jun 15, 2026
c0babc3
chore: gofmt preview_test.go
ipanta Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/agent/preview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"strings"
)

var reTransientUserBlock = regexp.MustCompile(`(?s)^\s*<(?:reasoning-language|memory-update|background-jobs)>.*?</(?:reasoning-language|memory-update|background-jobs)>\s*\n?`)
var reTransientUserBlock = regexp.MustCompile(`(?s)^\s*<(?:reasoning-language|memory-update|background-jobs|active-goal)>.*?</(?:reasoning-language|memory-update|background-jobs|active-goal)>\s*\n?`)

// StripTransientUserBlocks removes controller-injected transient XML blocks
// from persisted user messages before deriving display text, previews, or
Expand Down
23 changes: 23 additions & 0 deletions internal/agent/preview_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package agent_test

import (
"reasonix/internal/agent"
"testing"
)

func TestStripTransientBlocksActiveGoal(t *testing.T) {
tests := []struct {
in, want string
}{
{"<active-goal>\nFix all bugs\n</active-goal>\n\nfix the auth bug", "fix the auth bug"},
{"<reasoning-language>\nuse Chinese\n</reasoning-language>\n\n<active-goal>\nDo X\n</active-goal>\n\nhelp me", "help me"},
{"<memory-update>\n- note\n</memory-update>\n\n<active-goal>\nGoal text\n</active-goal>\n\ndo it", "do it"},
{"<active-goal>\n\nmulti-line\ngoal\n</active-goal>\n\nuser text", "user text"},
}
for _, tt := range tests {
got := agent.StripTransientUserBlocks(tt.in)
if got != tt.want {
t.Errorf("StripTransientUserBlocks(%q) = %q, want %q", tt.in, got, tt.want)
}
}
}