fix(cli): route slog.Warn/Error to TUI Notice events during chat session#4518
Open
lizhengwu wants to merge 1 commit into
Open
fix(cli): route slog.Warn/Error to TUI Notice events during chat session#4518lizhengwu wants to merge 1 commit into
lizhengwu wants to merge 1 commit into
Conversation
Prevent raw-mode stderr writes from corrupting the TUI display by replacing the default slog.Logger with one that writes Warn and above as event.Notice into the TUI event channel. Info/Debug are discarded. The original logger is restored before plugin cleanup.
github-actions
Bot
added
tui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reasonix chat TUI mode, when MCP plugin timeouts or background tasks call slog.Warn/Error, the logs write directly to stderr, corrupting Bubble Tea's alt-screen terminal display.
This PR routes Warn-and-above logs through the TUI event channel during the TUI lifecycle, so they render inline in the scrollback instead of writing to stderr.
Before / After
Before: stderr logs interleave at the top of the TUI, breaking the layout.
After: logs appear as warning notices inline in the TUI scrollback:
Scope