feat: Add pending status for Amazon orders awaiting shipment#9
Merged
eshaffer321 merged 1 commit intomainfrom Jan 2, 2026
Merged
feat: Add pending status for Amazon orders awaiting shipment#9eshaffer321 merged 1 commit intomainfrom
eshaffer321 merged 1 commit intomainfrom
Conversation
Orders that haven't shipped yet (no bank charges) are now tracked as "pending" instead of "failed". This provides clearer status reporting and ensures these orders are retried on subsequent syncs. Changes: - Add ErrPaymentPending sentinel error for orders not yet charged - Amazon handler detects pending orders and returns skip with reason - Orchestrator records pending status (not error) and logs at INFO level - UI already supports pending status with amber badge; added filter option The pending status is recorded in the database but doesn't block retries since IsProcessed() only checks for status='success'.
d506e30 to
64abf2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orders that haven't shipped yet (no bank charges) are now tracked as "pending" instead of "failed". This provides clearer status reporting and ensures these orders are retried on subsequent syncs.
Problem: When an Amazon order is placed but hasn't shipped yet, there are no bank transactions to match. Previously this was logged as an ERROR and recorded as "failed", which was misleading since the order isn't actually broken - it's just not ready yet.
Solution:
ErrPaymentPendingsentinel error for orders awaiting shipmentChanges
internal/adapters/providers/amazon/order.go- AddErrPaymentPendingerror and improvedGetFinalCharges()logicinternal/adapters/providers/amazon/order_test.go- Add tests for pending scenariosinternal/adapters/providers/amazon/provider_test.go- Update existing testsinternal/application/sync/handlers/amazon.go- Detect pending and return skipinternal/application/sync/orchestrator.go- Handle pending inhandleResult()internal/application/sync/recording.go- AddrecordPending()functionweb/src/app/(app)/orders/page.tsx- Add "Pending" to status filter dropdownTest plan
go test ./...)