Skip to content

Introducing setting scope (local/global)#197

Merged
DenysGonchar merged 2 commits intomasterfrom
adding-scope-for-amoc-settings
May 4, 2026
Merged

Introducing setting scope (local/global)#197
DenysGonchar merged 2 commits intomasterfrom
adding-scope-for-amoc-settings

Conversation

@DenysGonchar
Copy link
Copy Markdown
Collaborator

@DenysGonchar DenysGonchar commented Apr 27, 2026

added scope for configuration parameters.
• global parameters can be set on master node only, also they are automatically propagated to the slave nodes.
• local paramteres can be set per node.

also fixed amoc_throttle:stop() for throttles with gradually changing rates

@DenysGonchar DenysGonchar force-pushed the adding-scope-for-amoc-settings branch 3 times, most recently from b47b493 to 06bb385 Compare April 27, 2026 08:47
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 66.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.01%. Comparing base (97fb8ca) to head (890a7c5).

Files with missing lines Patch % Lines
src/amoc_controller.erl 44.44% 5 Missing ⚠️
src/dist/amoc_dist.erl 0.00% 5 Missing ⚠️
src/config/amoc_config_scenario.erl 90.00% 2 Missing ⚠️
src/config/amoc_config_verification.erl 66.66% 2 Missing ⚠️
src/throttle/amoc_throttle_controller.erl 66.66% 2 Missing ⚠️
src/config/amoc_config_attributes.erl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   76.81%   77.01%   +0.20%     
==========================================
  Files          32       32              
  Lines        1169     1201      +32     
==========================================
+ Hits          898      925      +27     
- Misses        271      276       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenysGonchar DenysGonchar force-pushed the adding-scope-for-amoc-settings branch 12 times, most recently from ed5d3f2 to 83eb6c1 Compare April 29, 2026 10:08
@DenysGonchar DenysGonchar marked this pull request as ready for review April 29, 2026 11:33
Comment thread integration_test/extra_code_paths/path1/dummy_helper.erl Outdated
Comment thread integration_test/extra_code_paths/path2/dummy_scenario.erl Outdated
Comment thread src/config/amoc_config_scenario.erl
Comment thread test/throttle_SUITE.erl
@DenysGonchar DenysGonchar force-pushed the adding-scope-for-amoc-settings branch from 83eb6c1 to 95bd45f Compare April 29, 2026 13:21
Comment thread src/config/amoc_config_scenario.erl Outdated
Comment thread src/amoc_controller.erl Outdated
@DenysGonchar DenysGonchar force-pushed the adding-scope-for-amoc-settings branch from 95bd45f to 890a7c5 Compare May 4, 2026 12:11
@DenysGonchar DenysGonchar merged commit 1d934e6 into master May 4, 2026
6 checks passed
@DenysGonchar DenysGonchar deleted the adding-scope-for-amoc-settings branch May 4, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants