test: simplify playwright storage access in persistence tests#451
Merged
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Playwright v1.61.0 adds a new WebStorage API via
page.localStorageandpage.sessionStoragefor reading and writing storage on the current origin.This PR uses that API to simplify our persistence e2e tests and avoid unnecessary
page.evaluate()calls forlocalStorageaccess.What changes did you make? (Give an overview)
Replaced
localStoragereads, writes, and removals withpage.localStorage.getItem(),setItem(), andremoveItem(). Also simplified hash inspection by reading frompage.url().Related Issues
Is there anything you'd like reviewers to focus on?