Skip to content

fix: continue sponsor data fetch when one source fails#995

Open
sethamus wants to merge 3 commits intoeslint:mainfrom
sethamus:issue949
Open

fix: continue sponsor data fetch when one source fails#995
sethamus wants to merge 3 commits intoeslint:mainfrom
sethamus:issue949

Conversation

@sethamus
Copy link
Copy Markdown
Contributor

@sethamus sethamus commented Apr 9, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR fixes the sponsor data fetch flow so a failure from one upstream source does not cause the entire fetch:sponsors script to fail.

What changes did you make? (Give an overview)

Updated tools/fetch-sponsors.js so the Open Collective, GitHub Sponsors, and thanks.dev fetches each handle their own failure during the Promise.all() call. If one source rejects, the script now logs the error and falls back to empty data for that source, allowing the rest of the sponsor data to still be written.

Related Issues

Fixes #949

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 9, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/69e35b0ec120a100098af42f
😎 Deploy Preview https://deploy-preview-995--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/69e35b0e19addd0008cc9fbb
😎 Deploy Preview https://deploy-preview-995--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/69e35b0e4582970008e7f6e8
😎 Deploy Preview https://deploy-preview-995--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/69e35b0e19addd0008cc9fb6
😎 Deploy Preview https://deploy-preview-995--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/69e35b0ec4cf2a0008508942
😎 Deploy Preview https://deploy-preview-995--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 9, 2026
@eslint-github-bot eslint-github-bot bot mentioned this pull request Apr 9, 2026
3 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/69e35b0ebadd3600089c2269
😎 Deploy Preview https://deploy-preview-995--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/69e35b0ec120a100098af434
😎 Deploy Preview https://deploy-preview-995--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 1a9d1b0
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/69e35b0ea453620008b69669
😎 Deploy Preview https://deploy-preview-995--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the fetch:sponsors data-fetch script to be resilient to individual upstream sponsor-source failures so that one rejected fetch doesn’t abort the entire run (addressing #949).

Changes:

  • Wrapes Open Collective, GitHub Sponsors, and thanks.dev fetches with per-promise .catch() handlers during Promise.all().
  • Logs per-source fetch failures and falls back to empty sponsor/donation data for the failing source.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/fetch-sponsors.js
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Apr 9, 2026
@mdjermanovic mdjermanovic moved this from Triaging to Implementing in Triage Apr 9, 2026
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. I also agree that we should retain existing data.

In addition, we should still ideally have the CI job marked as failed after writing the file. Otherwise, we could silently be missing data for months and not know until someone logs at the logs.

@sethamus
Copy link
Copy Markdown
Contributor Author

I believe I’ve addressed all the feedback here.

Comment thread tools/fetch-sponsors.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working contributor pool

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

Bug: data-fetch is failing

5 participants