Skip to content

chore: add lint:unused script to run Knip#724

Merged
DMartens merged 6 commits intomainfrom
chore/configure-knip
Feb 20, 2026
Merged

chore: add lint:unused script to run Knip#724
DMartens merged 6 commits intomainfrom
chore/configure-knip

Conversation

@Pixel998
Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Adds Knip to check for unused exports, unused dependencies, and missing dependencies

What changes did you make? (Give an overview)

  • Added knip.json config and a root lint:unused script.
  • Added a "Lint Files, Dependencies, & Exports" step to our CI.
  • Deleted unused packages/espree/lib/features.js

Related Issues

#695

Is there anything you'd like reviewers to focus on?

Comment thread knip.json Outdated
Copy link
Copy Markdown
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 .

Config relies on plugin auto-detection - Main entry points (espree.js, lib/index.js) aren't explicitly listed. Knip's plugins auto-detect them from package.json (exports, main fields) and devDependencies. Works fine but less explicit.

Comment thread package.json
Comment thread package.json Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Feb 10, 2026
@DMartens DMartens moved this from Needs Triage to Triaging in Triage Feb 11, 2026
@DMartens DMartens moved this from Triaging to Implementing in Triage Feb 11, 2026
@nzakas
Copy link
Copy Markdown
Member

nzakas commented Feb 11, 2026

@Pixel998 can you take a look at the comments and merge conflicts?

@github-actions github-actions Bot removed the Stale label Feb 11, 2026
Copy link
Copy Markdown

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens DMartens merged commit 92594f4 into main Feb 20, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Feb 20, 2026
@DMartens DMartens deleted the chore/configure-knip branch February 20, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants