chore: add tests for ESLint 8

[MichaelDeBoey]

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:

• eslint-config-eslint
  • PR
  • Release
• eslint-plugin-jsdoc (Support ESLint 8.x gajus/eslint-plugin-jsdoc#791)
  • feat: support ESLint 8.x gajus/eslint-plugin-jsdoc#792
  • v37.0.0
• eslint-plugin-node (Support ESLint 8.x mysticatea/eslint-plugin-node#294)
  • chore(CI): add tests for ESLint 7 mysticatea/eslint-plugin-node#224
  • feat: support ESLint 8.x mysticatea/eslint-plugin-node#295
  • Release

---

Closes #194

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

• The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

• The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag must be one of the following:

  The Tag is one of the following:

  • Fix - for a bug fix.
  • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
  • New - implements a new feature.
  • Breaking - for a backwards-incompatible enhancement or feature.
  • Docs - changes to documentation only.
  • Build - changes to build process only.
  • Upgrade - for a dependency upgrade.
  • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

  You can use the labels of the issue you are working on to determine the best tag.

• There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @MichaelDeBoey!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

Read more about contributing to ESLint here

[btmills]

Wow, thanks! There are a lot of good improvements in here. While we wait for any remaining dev dependencies to be ready for ESLint 8, would you mind splitting out some smaller changes that can be merged right away? Some ideas for sub-PRs:

• Add the matrix build for ESLint v6 and v7 in CI.
• Upgrade the local dev dependencies to ESLint v7 (and auto-fixing .eslintrc.js with the eslint-config-eslint upgrade).
• Test with the ESLint class API in v7.

[btmills]

Thank you for splitting those out so we could merge as much as possible already. Where does that leave this PR now? Are we just waiting for dependencies to be updated so we can add v8 to the matrix build?

[MichaelDeBoey]

@btmills This can be merged as is, as all tests are green for ESLint 8

[btmills]

Nice! It's good to see the tests explicitly confirming this all works across 6, 7, and 8. Thanks for making this happen!