Skip to content

fix: defer TabClosed cleanup to prevent window-switching error #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idmyn wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −11
Open

fix: defer TabClosed cleanup to prevent window-switching error #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions lua/codediff/ui/lifecycle/cleanup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,19 +176,21 @@ function M.setup_autocmds()
vim.api.nvim_create_autocmd("TabClosed", {
group = augroup,
callback = function()
-- TabClosed doesn't give us the tab number, so we need to scan
-- Remove any diffs for tabs that no longer exist
local valid_tabs = {}
for _, tabpage in ipairs(vim.api.nvim_list_tabpages()) do
valid_tabs[tabpage] = true
end
vim.schedule(function()
-- TabClosed doesn't give us the tab number, so we need to scan
-- Remove any diffs for tabs that no longer exist
local valid_tabs = {}
for _, tabpage in ipairs(vim.api.nvim_list_tabpages()) do
valid_tabs[tabpage] = true
end

local active_diffs = session.get_active_diffs()
for tabpage, _ in pairs(active_diffs) do
if not valid_tabs[tabpage] then
cleanup_diff(tabpage)
local active_diffs = session.get_active_diffs()
for tabpage, _ in pairs(active_diffs) do
if not valid_tabs[tabpage] then
cleanup_diff(tabpage)
end
end
end
end)
end,
})

Expand Down