Add ST7123 integrated touch support to M5Stack Tab5#616
Merged
Conversation
2 tasks
Agent-Logs-Url: https://github.com/esp-cpp/espp/sessions/3ad85902-651b-43d5-8f1d-d4c119604286 Co-authored-by: finger563 <213467+finger563@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix touch availability for m5stack tab5 ST7123
Add ST7123 integrated touch support to M5Stack Tab5
May 23, 2026
|
✅Static analysis result - no issues found! ✅ |
…er interface Agent-Logs-Url: https://github.com/esp-cpp/espp/sessions/7358df43-1e1a-4119-bdc3-37852bfec05e Co-authored-by: finger563 <213467+finger563@users.noreply.github.com>
Contributor
|
@Shadowtrance LMK if you're able to test the code on this branch on your hardware :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
st7123touchcomponent and added touch support tom5stack-tab5TouchDriverConcept+ type-erasedITouchDriver/TouchDriverAdapter/make_touch_drivertost7123touch.hppm5stack-tab5.hppwith onestd::shared_ptr<espp::ITouchDriver>touchpad.cppto use concept-based single pointer (cleaner, no if/else branching)st7123touchexample (CMakeLists.txt,sdkconfig.defaults,Kconfig.projbuild,README.md,st7123touch_example.cpp)build.yml(betweenst25dvandstate_machine, targetesp32s3)EXAMPLE_PATHdoc/en/input/st7123touch.rstwith toctree entry and concept descriptiondoc/en/input/st7123touch_example.mdValidated on newer variant of m5stack tab5 and ensured that the touch works properly.
Logs: