feat(bsp): Add Kconfig configuration for the BSP components interrupt task#654
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each BSP component that owns an
espp::Interruptpreviously hard-coded (or defaulted) the interrupt handler task's priority and left it unpinned, with no way to change them without editing the component. This adds two Kconfig options per component, wired into theespp::Interrupt'stask_config:<PREFIX>_INTERRUPT_PRIORITY—int, range0 25, FreeRTOS priority of the GPIO interrupt handler task (0 = lowest).<PREFIX>_INTERRUPT_CORE_ID—int, range-1 1, core to pin the handler task to (-1= not pinned).These are wired as
.priority = CONFIG_<PREFIX>_INTERRUPT_PRIORITY, .core_id = CONFIG_<PREFIX>_INTERRUPT_CORE_IDin theTask::BaseConfig(placed afterstack_size_bytes, matching the struct's field order).Defaults preserve existing behavior:
byte90andt-deckpreviously hard-coded.priority = 20, so their..._INTERRUPT_PRIORITYdefaults to20.0...._INTERRUPT_CORE_IDto-1(unpinned), matching the prior behavior.Components updated (15):
byte90,esp-box,esp32-p4-function-ev-board,esp32-timer-cam,m5stack-tab5,matouch-rotary-display,motorgo-mini,qtpy,seeed-studio-round-display,smartpanlee-sc01-plus,t-deck,t-dongle-s3,ws-s3-geek,ws-s3-lcd-1-47,ws-s3-touch.Motivation and Context
The interrupt handler task runs all of a board's GPIO callbacks (buttons, touch INT, etc.). Depending on the application, users may need that task to run at a higher priority (so input is serviced promptly relative to their own tasks) or pinned to a specific core (to keep it off a core doing latency-sensitive work). Until now those values were baked into each BSP. Exposing them via Kconfig lets users tune the handler task per project without modifying the component, while keeping the previous behavior as the default.
How has this been tested?
task_configfields.stack_size_bytes→priority→core_id) matchesTask::BaseConfigin all components.byte90andt-deckkeepprioritydefault20; all others0; allcore_iddefault-1.esp32-p4-function-ev-board(targetesp32p4) andesp-box(targetesp32s3) examples clean.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
N/A
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud buil