feat: add per-device ACK control with handle invalidation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for sensors that don't acknowledge specific I2C commands. This enables support for devices like SCD4x, that don't ACK during wake-up from sleep mode: - Add 'disable_ack_check' field to i2c_dev_t structure - Implement i2c_dev_invalidate_handle() for dynamic reconfiguration - Use device flag in i2c_device_config_t creation - Add warning log when ACK checking is disabled
Contributor
Author
|
@trombik The v5.6 build checks are failing because the docker image doesn't seem to exist? |
Contributor
|
@quinkq Correct. I'll remove 5.6 from the matrix. |
Contributor
|
@quinkq Done. |
Contributor
|
This would also fix esp-idf-lib/scd4x#2 |
Contributor
|
Will be merged after testing on actual hardware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Adds support for sensors that don't acknowledge specific I2C commands.This enables support for devices like SCD4x, which doesn't send an ACK when waking from sleep mode, and was causing wake_up failures. Implemented the handle invalidation function to temporarily disable ACK checking just for this command.
Changes:
Tested WITHOUT real hardware - feedback appreciated.
Going to create a PR for SCD4x in a moment for the fix to be effective.