This repository was archived by the owner on Aug 9, 2022. It is now read-only.
Use cargo rather make to do the generation from the svd files#30
Open
YonasJ wants to merge 8 commits intoesp-rs:masterfrom
Open
Use cargo rather make to do the generation from the svd files#30YonasJ wants to merge 8 commits intoesp-rs:masterfrom
YonasJ wants to merge 8 commits intoesp-rs:masterfrom
Conversation
…uild without any manual steps (running make). One mystery is that newlines are not showing up in the generated files. lib.rs is just a stub required by Cargo.toml that is over-written.
…not be there, so it does not compile as often.
… formats the code.
…nker warnings produced by svd2rust.
|
I am wondering if this is going to be merged as I am finding that the makefile is not portable across platforms and wondering about getting this updated or should I be looking at possibly migrating this to cmake? I would like build esp32 to validate the asm!() changes in xtensa-lx/xtensa-lx-rt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that you can just compile the crate without needing to manually run make.
After this patch build.rs does all the work, cargo still does dependency checking.
just run cargo build and it will do all the work.