Conversation
On branch main Your branch is up to date with 'origin/main'. Changes to be committed: new file: packages/period-double-space/0.1.0/README.md new file: packages/period-double-space/0.1.0/_manifest.yml new file: packages/period-double-space/0.1.0/package.yml
There was a problem hiding this comment.
Apologies for not getting onto this more quickly
A very minimal valuable package replacing two spaces typed, with a period. It took us a short while to determine that regex: was required to permit this. No shell, script or potentially malicious code.
One very minor recommendation to avoid misleading others into thinking brackets in the trigger are necessary, but good to merge otherwise. I've let CoPilot do its stuff but I think it's running down an unnecessary rabbit-hole!
| @@ -0,0 +1,3 @@ | |||
| matches: | |||
| - regex: "(\ \ )" | |||
There was a problem hiding this comment.
Would you kindly amend this to the simplest - regex: ' ' or "\ \ " as suggested in https://discord.com/channels/884163483409731584/1013916990760554608/1466710043415150715, please, or shall I?
There was a problem hiding this comment.
Pull request overview
Adds a new Espanso package that turns a double-space into a period+space (macOS/mobile-style).
Changes:
- Introduces
period-double-spacepackage manifest metadata. - Adds Espanso match/replace rule intended to convert double spaces to
.. - Adds README with usage/background and credits.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/period-double-space/0.1.0/package.yml | Defines the regex match and replacement behavior for the package. |
| packages/period-double-space/0.1.0/_manifest.yml | Adds package metadata (name, description, version, tags, etc.). |
| packages/period-double-space/0.1.0/README.md | Documents purpose, credits, and testing notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| matches: | |||
| - regex: "(\ \ )" | |||
There was a problem hiding this comment.
regex: "(\ \ )" is likely invalid YAML: in YAML double-quoted strings, backslash starts an escape sequence, and \ is typically treated as an unknown/invalid escape. This can break parsing and prevent the package from loading. Use a YAML-safe representation (e.g., single quotes and/or a clearer regex like {2}) so the file parses correctly and the intended “two spaces” match is unambiguous.
| - regex: "(\ \ )" | |
| - regex: '( {2})' |
There was a problem hiding this comment.
It's not invalid, but as I pointed out the brackets are not needed. ' {2}' is perhaps the clearest of the alternatives, however.
| @@ -0,0 +1,7 @@ | |||
| name: "period-double-space" | |||
| title: "Period Double Space" | |||
| description: Add period with double-space, like macOS or smartphones. | |||
There was a problem hiding this comment.
The description reads a bit grammatically off (“Add period…”). Consider adjusting to something like “Add a period with a double-space, like macOS or smartphones.” since this shows up as user-facing package metadata.
| description: Add period with double-space, like macOS or smartphones. | |
| description: Add a period with a double-space, like macOS or smartphones. |
There was a problem hiding this comment.
Copilot is wrong - the replacement doesn't add a period with a double-space.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
On branch main
Your branch is up to date with 'origin/main'.
Changes to be committed:
new file: packages/period-double-space/0.1.0/README.md
new file: packages/period-double-space/0.1.0/_manifest.yml
new file: packages/period-double-space/0.1.0/package.yml