Skip to content

Add period-double-space package#215

Open
yellowwinner wants to merge 2 commits intoespanso:mainfrom
yellowwinner:main
Open

Add period-double-space package#215
yellowwinner wants to merge 2 commits intoespanso:mainfrom
yellowwinner:main

Conversation

@yellowwinner
Copy link

On branch main
Your branch is up to date with 'origin/main'.

Changes to be committed:
new file: packages/period-double-space/0.1.0/README.md
new file: packages/period-double-space/0.1.0/_manifest.yml
new file: packages/period-double-space/0.1.0/package.yml

 On branch main
 Your branch is up to date with 'origin/main'.

 Changes to be committed:
	new file:   packages/period-double-space/0.1.0/README.md
	new file:   packages/period-double-space/0.1.0/_manifest.yml
	new file:   packages/period-double-space/0.1.0/package.yml
@yellowwinner yellowwinner changed the title Committer: Allen <allen@62e32fa74001> Add period-double-space package Jan 30, 2026
@smeech smeech requested a review from Copilot March 25, 2026 14:34
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not getting onto this more quickly ☹️.

A very minimal valuable package replacing two spaces typed, with a period. It took us a short while to determine that regex: was required to permit this. No shell, script or potentially malicious code.

One very minor recommendation to avoid misleading others into thinking brackets in the trigger are necessary, but good to merge otherwise. I've let CoPilot do its stuff but I think it's running down an unnecessary rabbit-hole!

@@ -0,0 +1,3 @@
matches:
- regex: "(\ \ )"
Copy link
Collaborator

@smeech smeech Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you kindly amend this to the simplest - regex: ' ' or "\ \ " as suggested in https://discord.com/channels/884163483409731584/1013916990760554608/1466710043415150715, please, or shall I?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Espanso package that turns a double-space into a period+space (macOS/mobile-style).

Changes:

  • Introduces period-double-space package manifest metadata.
  • Adds Espanso match/replace rule intended to convert double spaces to . .
  • Adds README with usage/background and credits.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/period-double-space/0.1.0/package.yml Defines the regex match and replacement behavior for the package.
packages/period-double-space/0.1.0/_manifest.yml Adds package metadata (name, description, version, tags, etc.).
packages/period-double-space/0.1.0/README.md Documents purpose, credits, and testing notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,3 @@
matches:
- regex: "(\ \ )"
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex: "(\ \ )" is likely invalid YAML: in YAML double-quoted strings, backslash starts an escape sequence, and \ is typically treated as an unknown/invalid escape. This can break parsing and prevent the package from loading. Use a YAML-safe representation (e.g., single quotes and/or a clearer regex like {2}) so the file parses correctly and the intended “two spaces” match is unambiguous.

Suggested change
- regex: "(\ \ )"
- regex: '( {2})'

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@smeech smeech Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not invalid, but as I pointed out the brackets are not needed. ' {2}' is perhaps the clearest of the alternatives, however.

@@ -0,0 +1,7 @@
name: "period-double-space"
title: "Period Double Space"
description: Add period with double-space, like macOS or smartphones.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description reads a bit grammatically off (“Add period…”). Consider adjusting to something like “Add a period with a double-space, like macOS or smartphones.” since this shows up as user-facing package metadata.

Suggested change
description: Add period with double-space, like macOS or smartphones.
description: Add a period with a double-space, like macOS or smartphones.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@smeech smeech Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot is wrong - the replacement doesn't add a period with a double-space.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants