Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Espanso Hub package that lets users insert gitmoji via the choice extension UI, showing emoji + shortcode + description before insertion.
Changes:
- Introduces a new
gitmoji-chooserpackage (v0.1.0) with a:gitmojitrigger that opens a choice picker and inserts the selected emoji. - Adds package metadata (
_manifest.yml) and end-user documentation (README.md) for Hub listing and installation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/gitmoji-chooser/0.1.0/package.yml | Defines the :gitmoji match and the choice list of gitmoji labels/IDs. |
| packages/gitmoji-chooser/0.1.0/_manifest.yml | Adds Hub metadata (name/title/description/version/author/tags/homepage). |
| packages/gitmoji-chooser/0.1.0/README.md | Documents usage, installation, and attribution/source for gitmoji data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title: "Gitmoji Chooser" | ||
| description: "A choice picker for all gitmoji emoji, triggered by :gitmoji" | ||
| version: 0.1.0 | ||
| author: "Dan Drake and Claude" |
There was a problem hiding this comment.
The _manifest.yml author field is typically a single person/handle across the repo; using "Dan Drake and Claude" is inconsistent with existing package manifests and may not display well in Hub metadata. Consider setting author to the package maintainer (e.g., Dan Drake) and (if desired) crediting other contributors/tools in the README instead.
| author: "Dan Drake and Claude" | |
| author: "Dan Drake" |
There was a problem hiding this comment.
I don't envisage this being an issue. Feel free to ignore.
There was a problem hiding this comment.
...also I find it very amusing that one AI chatbot is complaining about me crediting another chatbot. :)
(I put Claude in the authors because that's how I generated the YAML file; I didn't do any of the initial writing of that.)
smeech
left a comment
smeech
left a comment
There was a problem hiding this comment.
A nice simple single trigger with 75 potential single-character replacements presented via a choice form, in the same manner as my favourite, emoji-picker. No script, shell or potentially malicious code.
Co-Pilot hasn't found anything of concern.
A couple of minor recommendations, but good to merge otherwise.
| ## Installation | ||
|
|
||
| ``` | ||
| espanso install gitmoji-chooser |
There was a problem hiding this comment.
Not strictly necessary as the Hub page will automatically generate this, although I guess there may be a few people who browse the repo instead.
| espanso install gitmoji-chooser | ||
| ``` | ||
|
|
||
| Or manually place the `package.yml` file in your espanso match directory. |
There was a problem hiding this comment.
I tend to caution against recommending this please, because it's inclined to break espanso [package] install/uninstall etc. commands, by messing up the indexing I think.
| title: "Gitmoji Chooser" | ||
| description: "A choice picker for all gitmoji emoji, triggered by :gitmoji" | ||
| version: 0.1.0 | ||
| author: "Dan Drake and Claude" |
There was a problem hiding this comment.
I don't envisage this being an issue. Feel free to ignore.
| description: "A choice picker for all gitmoji emoji, triggered by :gitmoji" | ||
| version: 0.1.0 | ||
| author: "Dan Drake and Claude" | ||
| tags: ["gitmoji", "emoji", "git", "commit"] |
There was a problem hiding this comment.
The gitmojis package also has a "chat" tag. Would it be appropriate to include that too?
|
|
||
| Compare with the [gitmojis support](https://hub.espanso.org/gitmojis) package, which directly offers triggers for the gitmoji. This package uses the [choice extension](https://espanso.org/docs/matches/extensions/#choice-extension) for a nice UI. | ||
|
|
||
| ## Installation |
There was a problem hiding this comment.
Not strictly necessary as the Hub will add installation instructions automatically, but I suppose there may be a few people browsing the repo instead.
| espanso install gitmoji-chooser | ||
| ``` | ||
|
|
||
| Or manually place the `package.yml` file in your espanso match directory. |
There was a problem hiding this comment.
I tend to caution against manual installation, please? Placing packages in the match/packages folder tends to break Espanso's package commands by interfering with the indexing. I note that's not exactly what you've recommended but in the match folder it may get overwritten by other package.yml files, and it's not available for Espanso's package commands.
Another package for inserting gitmoji; this one uses the choice extension to allow the user to see the gitmoji and their descriptions while selecting.