Update Plurals translation docs for ICU MessageFormat#155
Open
bdraco wants to merge 1 commit into
Open
Conversation
The frontend migrated pluralization to ICU MessageFormat in esphome/device-builder-frontend#750, so the _singular/_plural key convention no longer applies. Update the Plurals section to describe the single-key ICU MessageFormat syntax. Fixes esphome/device-builder#1448
✅ Deploy Preview for esphome-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
PR Review — Update Plurals translation docs for ICU MessageFormatAccurate, well-written docs update. Merge-ready.
Checklist
Automated review by Kōan (Claude) |
esphbot
approved these changes
Jun 14, 2026
esphbot
left a comment
esphbot
left a comment
Contributor
There was a problem hiding this comment.
No blocking issues found.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the translation contributor documentation to reflect the Device Builder frontend’s switch from _singular/_plural translation keys to single-key ICU MessageFormat pluralization.
Changes:
- Replaces the old “paired keys” pluralization guidance with ICU MessageFormat syntax and an example.
- Adds brief guidance on plural categories (e.g.,
one,few,many,other) and how Lokalise presents them. - Notes that the
_singular/_pluralsuffix convention is no longer used and links the Lokalise ICU guide.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Device Builder frontend moved pluralization to ICU MessageFormat in esphome/device-builder-frontend#750, so the old
_singular/_pluralkey convention no longer applies. This updates the Plurals section of the translation guide to describe the single-key ICU MessageFormat syntax, and links the Lokalise ICU guide for reference.Fixes #156