Persist the expert_mode preference the frontend already writes#1480
Closed
bdraco wants to merge 1 commit into
Closed
Persist the expert_mode preference the frontend already writes#1480bdraco wants to merge 1 commit into
bdraco wants to merge 1 commit into
Conversation
14ee8ad to
7f85dd9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 222 222
Lines 17253 17254 +1
=======================================
+ Hits 17168 17169 +1
Misses 85 85
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
folded into #1445 final wire shape to be BEGINNER = “beginner” or EXPERT = “expert” and drop UI = “ui”, / YAML = “yaml” |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The frontend's Expert Mode toggle writes
expert_modeviaconfig/set_preferences, but the backendUserPreferencesmodel never had the field, so mashumaro dropped it on write andget_preferencesnever returned it; the toggle reset to off on every reload. Addsexpert_mode: boolto the model so the existing get/set path persists it. Backend only; the frontend already reads and writes the field.Related issue or feature (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocsmaintenancecidependenciesFrontend coordination
Checklist
ruff,codespell, yaml/json/python checks).tests/where applicable.components.index.json/definitions/components/*.jsonhave not been hand-edited (regenerate viascript/sync_components.pyif a sync is needed).docs/ARCHITECTURE.mdand/ordocs/API.md.