refactor: standardize operations consistency

app/operations/event_procedures/association_resolvable.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module EventProcedures
+  module AssociationResolvable
+    def find_or_create_patient(patient_attributes)
+      Patients::FindOrCreate.result(params: patient_attributes).patient
+    end
+
+    def find_or_create_procedure(procedure_attributes)
+      Procedures::FindOrCreate.result(params: procedure_attributes).procedure
+    end
+
+    def find_or_create_health_insurance(health_insurance_attributes)
+      HealthInsurances::FindOrCreate.result(params: health_insurance_attributes).health_insurance
+    end
+  end
+end

app/operations/event_procedures/create.rb

@@ -2,6 +2,8 @@
 
 module EventProcedures
   class Create < Actor
+    include AssociationResolvable
+
     input :attributes, type: Hash
     input :user_id, type: Integer
 
@@ -35,9 +37,9 @@ def create_event_procedure
     end
 
     def event_procedure_attributes
-      patient = find_or_create_patient
-      procedure = find_or_create_procedure
-      health_insurance = find_or_create_health_insurance
+      patient = find_or_create_patient(attributes[:patient_attributes])
+      procedure = find_or_create_procedure(attributes[:procedure_attributes])
+      health_insurance = find_or_create_health_insurance(attributes[:health_insurance_attributes])
 
       validate_procedure(procedure)
       validate_health_insurance(health_insurance)
@@ -73,18 +75,6 @@ def merge_attributes(patient, procedure, health_insurance)
         )
     end
 
-    def find_or_create_health_insurance
-      HealthInsurances::FindOrCreate.result(params: attributes[:health_insurance_attributes]).health_insurance
-    end
-
-    def find_or_create_patient
-      Patients::FindOrCreate.result(params: attributes[:patient_attributes]).patient
-    end
-
-    def find_or_create_procedure
-      Procedures::FindOrCreate.result(params: attributes[:procedure_attributes]).procedure
-    end
-
     def log_success
       Rails.logger.info(
         ">>> EventProcedure created successfully. ID: #{event_procedure.id}, User ID: #{user_id}"

app/operations/event_procedures/update.rb

@@ -2,6 +2,8 @@
 
 module EventProcedures
   class Update < Actor
+    include AssociationResolvable
+
     input :id, type: String
     input :attributes, type: Hash
 
@@ -22,18 +24,6 @@ def find_event_procedure
       EventProcedures::Find.result(id: id).event_procedure
     end
 
-    def find_or_create_patient(patient_attributes)
-      Patients::FindOrCreate.result(params: patient_attributes).patient
-    end
-
-    def find_or_create_procedure(procedure_attributes)
-      Procedures::FindOrCreate.result(params: procedure_attributes).procedure
-    end
-
-    def find_or_create_health_insurance(health_insurance_attributes)
-      HealthInsurances::FindOrCreate.result(params: health_insurance_attributes).health_insurance
-    end
-
     def handle_update_procedure(event_procedure)
       event_procedure.assign_attributes(handled_attributes)
       total_amount_cents = recalculated_total_amount(event_procedure)

app/operations/medical_shifts/update.rb

@@ -8,9 +8,15 @@ class Update < Actor
     output :medical_shift, type: MedicalShift
 
     def call
-      self.medical_shift = MedicalShift.find(id)
+      self.medical_shift = find_medical_shift
 
       fail!(error: :invalid_record) unless medical_shift.update(attributes)
     end
+
+    private
+
+    def find_medical_shift
+      MedicalShifts::Find.result(id: id).medical_shift
+    end
   end
 end

spec/operations/medical_shifts/update_spec.rb

@@ -24,6 +24,14 @@
       end
     end
 
+    context "when medical_shift with given id does not exist" do
+      it "raises ActiveRecord::RecordNotFound" do
+        expect do
+          described_class.result(id: "non-existent-id", attributes: {})
+        end.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
     context "with invalid attributes" do
       it "is failure" do
         medical_shift = create(:medical_shift, workload: MedicalShifts::Workloads::SIX)