Tuki konttien ajamiseen kirjoitussuojatussa-tiedostojärjestessä#8585
Closed
Tuki konttien ajamiseen kirjoitussuojatussa-tiedostojärjestessä#8585
Conversation
ilja-git
force-pushed
the
feat/read-only-nginx
branch
6 times, most recently
from
140ea08 to
6cc01bd
Compare
ilja-git
changed the title
ilja-git
force-pushed
the
feat/read-only-nginx
branch
4 times, most recently
from
54d32c9 to
55a319e
Compare
Wnt
reviewed
Mar 3, 2026
| RUN yarn workspaces focus --production \ | ||
| && yarn cache clean --all | ||
|
|
||
| USER evaka |
Contributor
There was a problem hiding this comment.
Ajautuuko entrtpoint ja esim s3download tämän muutoksen jälkeen root-käyttäjänä?
Contributor
Author
There was a problem hiding this comment.
Ajautuu. Käyttäjä vaihdetaan evaka käyttäjään kun itse ohjelma ajetaan entrypointissa viimeisenä.
Contributor
There was a problem hiding this comment.
Tästä aiheutuu varmaan sitten toisenlainen alertti AWS Security Hubissa. Uskoisin, että siellä tarkastellaan myös, että Dockerfile vaihtaa käyttäjän non-rootiksi
ilja-git
force-pushed
the
feat/read-only-nginx
branch
from
55a319e to
c06a34b
Compare
Wnt
reviewed
Mar 5, 2026
| @@ -47,19 +47,25 @@ if [ "${DEPLOYMENT_BUCKET:-X}" != 'X' ]; then | |||
| s3download "$DEPLOYMENT_BUCKET" "proxy" /etc/nginx/ | |||
Contributor
There was a problem hiding this comment.
Eikös tämä koita ladata tiedostoja RO mountatuun tiedostojärjestelmään?
ilja-git
force-pushed
the
feat/read-only-nginx
branch
4 times, most recently
from
4c1c88d to
c1283f2
Compare
Replace gosu-based privilege dropping with Dockerfile USER directive. Fargate automatically creates ephemeral storage for VOLUME paths with ownership inherited from the image, eliminating the need for ECS-level volume definitions and root entrypoints. - Remove gosu from service and apigw Dockerfiles - Add chown + VOLUME + USER to all three Dockerfiles - Fix proxy s3download to write to writable volume instead of /etc/nginx - Remove unnecessary 'user nginx' directive from nginx.conf.template - Add read_only + tmpfs to docker-compose.e2e.yml for local parity
ilja-git
force-pushed
the
feat/read-only-nginx
branch
2 times, most recently
from
29f1564 to
c4db881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mahdollista Nginxin ajaminen read-only-volumella siten, että vain
/nginx-hakemistoon on kirjoitusoikeus.