fix(nimble): Dynamic services fixes#100
Open
nebkat wants to merge 2 commits intoespressif:nimble-1.6.0-idffrom
Open
fix(nimble): Dynamic services fixes#100nebkat wants to merge 2 commits intoespressif:nimble-1.6.0-idffrom
nebkat wants to merge 2 commits intoespressif:nimble-1.6.0-idffrom
Conversation
When no non-dynamic services have been added the ble_gatts_clt_cfg_pool is empty. Because of this, it reports having no free blocks, as if it was full. We must check if there are any blocks available at all, in case they are all stored in dynamic services.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have identified two issues that occur when using only dynamic services:
ble_gatts_get_last_cfgis used which may initially returnNULLif there are no static services - this needs to be checked.ble_gatts_conn_can_allocmay wrongly returnfalsebecause there are no free blocks in theble_gatts_clt_cfg_pool, which is empty due to there being no static services.Checklist
Before submitting a Pull Request, please ensure the following: