Make NVS namespace adjustable#97
Open
vodka-bears wants to merge 1 commit intoespressif:nimble-1.6.0-idffrom
Open
Make NVS namespace adjustable#97vodka-bears wants to merge 1 commit intoespressif:nimble-1.6.0-idffrom
vodka-bears wants to merge 1 commit intoespressif:nimble-1.6.0-idffrom
Conversation
Introduce static string nimble_nvs_namespace that is used instead of the old NIMBLE_NVS_NAMESPACE macro. Add function int ble_store_set_namespace(const char * namespace_str) that allows for changing namespace string. Rename NIMBLE_NVS_NAMESPACE to NIMBLE_NVS_NAMESPACE_DEFAULT. Replace occurrences of macro NIMBLE_NVS_NAMESPACE with variable nimble_nvs_namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Developing a custom project I realized that I need to run several devices with different addresses on the same hardware. The purpose of the change is to make it possible.
I abstained from mentioning the new function in any headers. Users can make a forward declaration if they need to change the namespace string.
Related
Fixes #95
Testing
Works well in my project. Bonds separately to the same host or to multiple hosts and bonding remains consistent and isolated.
Checklist
Before submitting a Pull Request, please ensure the following: