Skip to content

refactor(usb): Change critical section API#74

Draft
peter-marcisovsky wants to merge 1 commit intomasterfrom
refactor/change_critical_section_api
Draft

refactor(usb): Change critical section API#74
peter-marcisovsky wants to merge 1 commit intomasterfrom
refactor/change_critical_section_api

Conversation

@peter-marcisovsky
Copy link
Copy Markdown
Collaborator

Description

As per idf-core team recommendations, this MR updates a Critical section API to a new one.

Related

Closes IDF-11361

Testing

To pass CI tests


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@peter-marcisovsky
Copy link
Copy Markdown
Collaborator Author

peter-marcisovsky commented Oct 7, 2024

esp_private/critical_section.h is not present in IDF 5.0.
Updating to new critical section API is a preparation for IDF 6.0 support. By the time IDF 6.0 is released, IDF 5.0 will probably go EOL, and we will be able to merge this. On hold for now.

@peter-marcisovsky peter-marcisovsky self-assigned this Oct 8, 2024
@tore-espressif tore-espressif marked this pull request as draft November 15, 2024 07:56
@peter-marcisovsky peter-marcisovsky force-pushed the refactor/change_critical_section_api branch from e8f4b39 to 9789f3a Compare May 20, 2025 12:19
@peter-marcisovsky peter-marcisovsky force-pushed the refactor/change_critical_section_api branch from 9789f3a to b9f4769 Compare August 27, 2025 11:31
@peter-marcisovsky peter-marcisovsky marked this pull request as ready for review August 27, 2025 11:43
@peter-marcisovsky peter-marcisovsky force-pushed the refactor/change_critical_section_api branch from b9f4769 to 206bd9a Compare August 27, 2025 13:36
@peter-marcisovsky peter-marcisovsky marked this pull request as draft August 27, 2025 15:20
@peter-marcisovsky
Copy link
Copy Markdown
Collaborator Author

Blocked by:

  • IDF-13950 Update critical section api to allow more flexible lock declaration

TL, DR: A new (or modified) critical section macro should allow to declare an extern lock, like so:
extern esp_os_spinlock_t lock_name;

Which is needed to update the UVC driver

@peter-marcisovsky peter-marcisovsky added Component: usb_host Issue affects usb_host component stall PR is stall due to low priority, or blocked by other PR labels Jan 13, 2026
@peter-marcisovsky peter-marcisovsky force-pushed the refactor/change_critical_section_api branch from 206bd9a to 93dcff4 Compare January 13, 2026 17:04
@peter-marcisovsky peter-marcisovsky force-pushed the refactor/change_critical_section_api branch from 93dcff4 to 8cae9bb Compare January 13, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: usb_host Issue affects usb_host component stall PR is stall due to low priority, or blocked by other PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant