fix(cbor): Fix build with picolibc (IEC-512)#718
Open
abobija wants to merge 1 commit intoespressif:masterfrom
Open
fix(cbor): Fix build with picolibc (IEC-512)#718abobija wants to merge 1 commit intoespressif:masterfrom
abobija wants to merge 1 commit intoespressif:masterfrom
Conversation
Build of project that uses `espressif/cbor^0.6.1~4` component fails with esp-idf v6.0+ using picolibc since picolibc does not have implementation of fopencookie function. By defining `__APPLE__` we are switching to picolibc supported `funopen` alternative.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Build of project that uses
espressif/cbor^0.6.1~4component and picolibc (with idf v6+) fails since picolibc does not have implementation offopencookiefunction andcookie_io_functions_ttypedef.By defining
__APPLE__we are switching to picolibc supportedfunopenalternative that makes project successfully compiled on idf v6+ using picolibc. Note thatCONFIG_LIBC_PICOLIBC_NEWLIB_COMPATIBILITYstill needs to be enabled to compile with picolibc, even if we switch to__APPLE__.It would be nice if cbor component could work without defining
CONFIG_LIBC_PICOLIBC_NEWLIB_COMPATIBILITYand rely completely on picolibc without any hacks.I've opened a PR in origin tinycbor's repo as well to support picolibc, so maybe we will accomplish something:
intel/tinycbor#319
Maybe to wait if intel's tinycbor is going to support picolibc...