New apps: bmoface, doomguy, and meseeks!#4041
New apps: bmoface, doomguy, and meseeks!#4041LucienStorm wants to merge 6 commits intoespruino:masterfrom
Conversation
New commit with app.png and hopefully all errors cleared.
Committing BMOface, Doomguy, and Mr MeSeeks, hopefully all errors have finally been cleared.
|
Never stop improving :) |
|
These look really nice :) |
|
Thanks for the apps! They appear to all be the same code but a different app for different images, are you able to combine them into one app? Perhaps that the user can select between when they install? |
|
I suppose I could, however these are three completely unrelated character themes, with different offerings on the clock info placement and interactivity. If you just want to switch between the faces/clocks, there are a couple apps that allow you to either schedule clocks, or cycle through them with a tap. |
|
Fair enough - I'll merge (once the lint is ok) but please bear in mind there's been 5 PRs, which I've read through all as they go, and each app is ~700 lines of code, so combined this takes up a lot of maintainer free-time |
|
I notice |
|
*facepalm* No, I didn't mean to add that one yet.
Would it be best at this time to cancel this one and retry with the 3 separate pull requests?
Lucien Storm
On October 30, 2025 8:08:21 AM CDT, Rob Pilling ***@***.***> wrote:
bobrippling left a comment (espruino/BangleApps#4041)
I notice `stardateclock_wbin` has appeared - did you mean to add that too?
--
Reply to this email directly or view it on GitHub:
#4041 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Through K-9 Mail on Android
|
|
Nah that's alright - I can tinker with the commits and just do the three if you're ok with that? |
|
I'm not sure if I responded to this, I'm ok with that. Thank you for your help.
Lucien Storm
On October 30, 2025 5:29:32 PM CDT, Rob Pilling ***@***.***> wrote:
bobrippling left a comment (espruino/BangleApps#4041)
Nah that's alright - I can tinker with the commits and just do the three if you're ok with that?
--
Reply to this email directly or view it on GitHub:
#4041 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Through K-9 Mail on Android
|
Sorry about it being 3 apps at once. I finally figured out how to run the npm test locally and worked on it until the errors were cleared.
|
Sorted :) will merge when the checks pass |
|
Looks like there's the lint firing, same as before if you get change to sort them: |
No description provided.