sleeplog: put use of HRM data behind a setting preferHRM#4156
Merged
thyttan merged 6 commits intoespruino:masterfrom Mar 2, 2026
Merged
sleeplog: put use of HRM data behind a setting preferHRM#4156thyttan merged 6 commits intoespruino:masterfrom
preferHRM#4156thyttan merged 6 commits intoespruino:masterfrom
Conversation
Collaborator
Author
|
This is not tested yet. |
Collaborator
|
Merge away when you're happy :) |
Contributor
|
Would it make more sense to have the |
Collaborator
Author
|
Yes I think so :) |
Collaborator
Author
|
Tried the latest changes tonight with a clean install. Seems to work OK. merging. |
Collaborator
Author
|
@RKBoss6 Could you give this a test tonight, enabling the hrm mode? I only tested movement mode last night. It's on the development app loader now. |
Contributor
|
Yep! I had installed the new version yesterday, but don't see any difference today... I'll look at it for a few more days to see. Edit: I'll check both hrm on and off |
Collaborator
Author
|
There's no change since the commits yesterday :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed around: https://github.com/orgs/espruino/discussions/7801#discussioncomment-15711051
Also previously here: #4023 (comment)