Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the iOS Integration app’s reliability when handling incoming ANCS notifications and related data (e.g., location), addressing crashes caused by missing fields and incorrect storage writes (Fixes #4175).
Changes:
- Bump iOS Integration app version to
0.25. - Fix location persistence by writing
mylocation.jsonviaStorage.writeJSON. - Prevent null/undefined errors during app name auto-detection by guarding
msg.appIdand adding a safer fallback.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/ios/metadata.json | Version bump to 0.25 for the iOS app release. |
| apps/ios/boot.js | Fixes JSON persistence for location and hardens notification parsing against missing appId. |
| apps/ios/ChangeLog | Adds a 0.25 entry describing stability improvements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Nice fix - tagged Gordon with this being a core app but LGTM |
Updated comment to clarify fallback behavior for name assignment.
Member
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4175, where the notifications would be received, but not displayed, due to null errors. Also fixes
storage.writeto bestorage.writeJSON, which previously threw an error if no json file was found.