Modernize#137
Draft
JoshTheWanderer wants to merge 15 commits into
Draft
Conversation
JoshTheWanderer
changed the title
Swap Sass for plain CSS modules, expose 18 theme values as CSS custom properties on .next-pagination, and add a linkComponent prop so consumers can inject a custom/wrapped next/link. Refs #82 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JoshTheWanderer
force-pushed
the
modernize
branch
from
08352d1 to
2811677
Compare
❌MegaLinter analysis: Error
Detailed Issues❌ REPOSITORY / trufflehog - 1 error❌ JSON / v8r - 1 error
|
allows us to ditch react-scripts, which is unmaintained and outdated
Next.js, Jest and Stylelint all resolve `.mjs` config variants. The `jest.style-mock` helper is loaded at runtime without a JS transform, so it stays CommonJS via the `.cjs` extension. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the legacy `.eslintrc` + `.eslintignore` pair with `eslint.config.mjs` using `@etchteam/eslint-config/nextjs`. Adds `stylelint` alongside so the repo has first-class lint scripts, and bumps the dev dependency set to match eslint 9 and the Next.js 16 peer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Auto-fixable changes from the new config (import-order sort, readonly props, prettier) plus one behavioural fix in `src/index.tsx`: swap the `useEffect` hydration guard for `router.isReady` to silence `react-hooks/set-state-in-effect` and drop the cascading render. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Move `stylelint` and `@etchteam/stylelint-config` to devDependencies (they are tooling, not runtime consumers) - Move `prop-types` to dependencies so published consumers resolve it for `Icon.propTypes` - Delete `src/react-app-env.d.ts`; `react-scripts` is no longer a dep and the file's directive was silently disabled by prettier Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Narrows `lint:css` to the source globs (excluding `dist/` and example build output) and runs `stylelint --fix` across the CSS/SCSS modules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Catches regressions that only surface when the example consumes the built package (e.g. broken `next.config.mjs`, peer-dep drift). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- `npm ci` against the example lockfile so drift fails CI instead of silently mutating the lockfile - Cache both lockfiles so example deps aren't re-downloaded each run - Assert the exported `index.html` exists — catches a next export that succeeds while emitting zero pages Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Set top-level permissions to none and grant minimum per job. Pin all actions to commit SHAs (checkout v6.0.2, setup-node v6.4.0, megalinter v9.4.0) and switch to `npm ci --no-scripts` to skip lifecycle scripts during dependency install. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ci: harden workflow permissions and pin actions
Update linting setup
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.