Update components to be compatible with php82 - #239
Open
toanhminh0412 wants to merge 40 commits into
Open
Conversation
Avoid passing null as the second param to explode
Avoid passing null to trim
Avoid passing null to json_decode
Avoid passing null as the second param to explode
Avoid passing null to rtrim
Fix getting offset of bool type
Avoid passing null to trim
Avoid passing null as the second param to preg_match_all
Avoid passing null to strtolower
Avoid passing null to strtolower
Avoid passing null to stripslashes
Avoid passing null to count
Avoid passing null to json_decode
Avoid passing null to stripslashes
Avoid passing null to stripslashes
Avoid passing null to stripslashes
leenapthine
reviewed
Nov 4, 2024
| ->set('group', $group) | ||
| ->set('customFields', $customFields) | ||
| ->set('customAnswers', $customFieldForm) | ||
| ->set('customAnswers', $customFieldForms) |
Collaborator
There was a problem hiding this comment.
I couldn't find where 'customFieldForms' is being created in the code. The change to pluralize 'form' to 'forms' here is intentional though?
Collaborator
Author
There was a problem hiding this comment.
No, good catch. I need to fix this at some point
Collaborator
|
Nice work Archie! I went through about half of the patch code, and then finished by going through all of your manual fixes where the patch needed tweaking. Everything looks good to me. |
toanhminh0412
requested review from
dleske and
leenapthine
and removed request for
leenapthine
December 13, 2024 22:37
eduardobassaniuvic
force-pushed
the
update-components-php82
branch
from
April 16, 2026 19:52
1880a8f to
045d70a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was done by:
diffing the core php8 code and core php5 code and applying them onto the current app code