Feature ETP-4687: Expand Intercompany docs with client feedback - #700
Merged
Conversation
Clarify that Bulk Completion is the only action that generates the inverse document for both invoices and orders (standard Complete/Book never apply the intercompany logic), document target Business Partner and price list validations, and add a Troubleshooting checklist. Move images out of assets/drive into a dedicated intercompany assets folder and add the correct Bulk Completion ES translation to the KB.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the Intercompany documentation (EN/ES) to reflect client feedback, clarifying that inverse documents are generated only via Bulk Completion, detailing validation rules, adding a troubleshooting checklist, and relocating screenshots into a dedicated assets/.../financial-extensions/intercompany/ folder. It also updates the ES terminology KB with the official translation for “Bulk Completion”.
Changes:
- Clarifies Intercompany processing flow: inverse docs are generated only through Bulk Completion, not standard Complete/Book actions.
- Expands configuration/validation guidance (Business Partner setup, price list checks, tax recalculation, discounts/promotions).
- Adds a troubleshooting checklist and moves/syncs screenshot assets; adds ES terminology entry for “Bulk Completion”.
Reviewed changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| overrides/assets/anais_translation_kb.json | Adds official ES terminology entry for “Bulk Completion” → “Completado Masivo”. |
| docs/user-guide/etendo-classic/optional-features/bundles/financial-extensions/intercompany.md | Updates EN Intercompany docs with Bulk Completion-only flow, validations, troubleshooting, and new asset paths. |
| docs/es/user-guide/etendo-classic/optional-features/bundles/financial-extensions/intercompany.md | Mirrors EN updates in ES (Completado Masivo flow, validations, troubleshooting) and updates asset paths. |
| docs/assets/user-guide/etendo-classic/optional-features/bundles/financial-extensions/intercompany/invoice-lines.png | Adds/moves screenshot into the new dedicated Intercompany assets directory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/drive/into a dedicatedassets/.../financial-extensions/intercompany/folder, matching the convention used by other pages.Bulk Completion→Completado MasivoES translation to the terminology KB.Both EN and ES pages updated.
Test plan
mkdocs build --strictpasses (only pre-existing, unrelated RSS plugin warning remains)🤖 Generated with Claude Code