Skip to content

⚡ Optimize SQLiteSpanExporter batch insertions #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eterna2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize SQLiteSpanExporter batch insertions #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions libs/kest-core/python/src/kest/core/telemetry/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,20 @@ def _init_db(self):
def export(self, spans):
"""Inserts a batch of spans into the SQLite database."""
with sqlite3.connect(self.db_path) as conn:
for span in spans:
conn.execute(
"INSERT OR REPLACE INTO spans (id, trace_id, name, start_time, end_time, attributes) VALUES (?, ?, ?, ?, ?, ?)",
conn.executemany(
"INSERT OR REPLACE INTO spans (id, trace_id, name, start_time, end_time, attributes) VALUES (?, ?, ?, ?, ?, ?)",
(
(
str(span.context.span_id),
str(span.context.trace_id),
span.name,
span.start_time,
span.end_time,
json.dumps(dict(span.attributes) if span.attributes else {}),
),
)
)
for span in spans
),
)
return True

def shutdown(self):
Expand Down
Loading