Skip to content

🔒 Security fix: Enforce JWT audience verification - #118

Open
eterna2 wants to merge 1 commit into
mainfrom
jules-3046650064226689549-7ea77c78
Open

🔒 Security fix: Enforce JWT audience verification#118
eterna2 wants to merge 1 commit into
mainfrom
jules-3046650064226689549-7ea77c78

Conversation

@eterna2

@eterna2 eterna2 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

🎯 What: Modified KestIdentityMiddleware to accept an audience parameter and removed the insecure verify_aud=False option when decoding JWTs via PyJWT.
⚠️ Risk: Without audience verification, JWTs issued for other clients or services could be used to authenticate requests, enabling potential token replay attacks across services.
🛡️ Solution: The middleware now safely passes the explicitly provided audience parameter down to PyJWT so it properly validates the token's aud claim. Added audience="account" to the configured middlewares in app.py, gateway.py, and agent.py to match the expected client tokens from Keycloak.


PR created automatically by Jules for task 3046650064226689549 started by @eterna2

🎯 What: Modified KestIdentityMiddleware to accept an audience parameter and removed the insecure verify_aud=False option when decoding JWTs via PyJWT.
⚠️ Risk: Without audience verification, JWTs issued for other clients or services could be used to authenticate requests, enabling potential token replay attacks across services.
🛡️ Solution: The middleware now safely passes the explicitly provided audience parameter down to PyJWT so it properly validates the tokens aud claim. Added audience="account" to the configured middlewares in app.py, gateway.py, and agent.py to match the expected client tokens from Keycloak.

Co-authored-by: eterna2 <1248825+eterna2@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant