Fix hook callback called multiple times in registerRoute#79
Merged
JohnMcLear merged 3 commits intomainfrom Apr 14, 2026
Merged
Conversation
The Etherpad hook system expects cb() to be called exactly once per hook invocation. In registerRoute, cb() was being called inside the /p/*/feed route handler on every HTTP request (up to 5 times per request depending on code path), in addition to the correct call at the end of the hook. This could cause unpredictable behavior in the hook system. Remove all cb() calls from inside route handlers, keeping only the single call after all routes are registered. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a systematic audit of all Etherpad plugins.
🤖 Generated with Claude Code