Skip to content

Reentrancy protection with optional parameter#3

Open
ShubhSensei wants to merge 1 commit into
ethereum-optimism:mainfrom
ShubhSensei:reentrancy_protection_key
Open

Reentrancy protection with optional parameter#3
ShubhSensei wants to merge 1 commit into
ethereum-optimism:mainfrom
ShubhSensei:reentrancy_protection_key

Conversation

@ShubhSensei
Copy link
Copy Markdown

#1

Reentrancy Protection

  • The child class cannot inherit the TransientReentrancyAware contract's modifier automatically.
  • Thus made a new modifier in the TransientContext contract itself.
  • The bytes32 key in the modifier is used to create separate locks, which do not interfere with each other to ensure atomic access.

@0xfuturistic
Copy link
Copy Markdown
Contributor

could we add tests for this @ShubhSensei?

@pegahcarter
Copy link
Copy Markdown

ping @ShubhSensei

@0xfuturistic
Copy link
Copy Markdown
Contributor

@pegahcarter would you like to give it a shot? you can make a new PR extending this one and adding tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants