Skip to content

Add Electra block and state objects from CL spec - #469

Merged
rolfyone merged 4 commits into
masterfrom
nflaig/electra-spec-objects
Sep 23, 2024
Merged

Add Electra block and state objects from CL spec#469
rolfyone merged 4 commits into
masterfrom
nflaig/electra-spec-objects

Conversation

@nflaig

@nflaig nflaig commented Aug 26, 2024

Copy link
Copy Markdown
Member

Adds Electra block and state objects from CL spec as per v1.5.0-alpha.5 release and modifications from ethereum/consensus-specs#3875

@rolfyone rolfyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread types/electra/block.yaml Outdated
@nflaig

nflaig commented Sep 16, 2024

Copy link
Copy Markdown
Member Author

need to apply changes from ethereum/consensus-specs#3875

@nflaig
nflaig marked this pull request as draft September 16, 2024 10:26
@ralexstokes

Copy link
Copy Markdown
Member

need to apply changes from ethereum/consensus-specs#3875

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data

this would be mirrored in the builder-specs so that we don't need to worry about execution requests leaking any MEV in the builder exchange

@nflaig

nflaig commented Sep 18, 2024

Copy link
Copy Markdown
Member Author

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data

makes sense, I applied the changes as per ethereum/builder-specs#101

@nflaig
nflaig marked this pull request as ready for review September 18, 2024 11:08

@ralexstokes ralexstokes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a somewhat quick skim, nice work!

Comment thread apis/validator/block.v3.yaml
@rolfyone

Copy link
Copy Markdown
Contributor

Merging this as it at least should be close, and smaller PRs will be easier to adjust if any slight tweaks need to be made.

@rolfyone
rolfyone merged commit 203410d into master Sep 23, 2024
@rolfyone
rolfyone deleted the nflaig/electra-spec-objects branch September 23, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants