Define electra types and apis - #105
Merged
Merged
Conversation
ralexstokes
reviewed
Oct 9, 2024
ralexstokes
reviewed
Oct 9, 2024
ralexstokes
left a comment
ralexstokes
left a comment
Member
There was a problem hiding this comment.
had one question but otherwise this looks great, thank you!!
if we update the beacon-apis submodule to at least 492bbbdbcad45249d9a8cd8c23e902c5dfe4ad28 then I think this will be final for pectra broadly
Member
|
also looks like the submodule update would help the linter errors |
nflaig
reviewed
Oct 9, 2024
ensi321
marked this pull request as ready for review
October 10, 2024 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add electra type definition and update apis to include new types.
Also update beacon apis submodule commit to
02d595daf39943430f54aa978f88a5c50d957e64Follow up of #101