Open
Conversation
e925ba8 to
3cd2778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduction of a method to standardise the extraction of a set of addresses that are involved in an Ethereum block.
Dependencies
This method involves use of the concept of an address
Appearance, defined here:Motivation
Documentation of the method allows different execution clients to implement the method. The method
itself is useful for obtaining knowledge that end-users can use (information about which transactions are relevant to their address). Multiple implementations allows detection of errors present in a single implementation through cross-client testing.
Background
The UnchainedIndex consists of "address appearances". It is a distributed index constructed by calling an Ethereum node using the trueblocks-core software (https://github.com/TrueBlocks/trueblocks-core). It finds addresses as they appear in each block and publishes the index. With this new method it could call a node to find addresses.
Changes made
Test case generator
A test case generator has been written (https://github.com/perama-v/unchained-reader). It uses data from the UnchainedIndex (and therefore trueblocks-core by extension) to create the
test cases for individual blocks.
An alternative test generator can be made with the
chifra blockscommand built into trueblocks-core.