perf(spec-tools,ci): parallel PR spec-doc builds, publish-only social cards - #3101
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3101 +/- ##
===================================================
+ Coverage 93.23% 93.30% +0.06%
===================================================
Files 624 624
Lines 36924 36986 +62
Branches 3373 3383 +10
===================================================
+ Hits 34427 34508 +81
+ Misses 1704 1695 -9
+ Partials 793 783 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
52d66d1 to
8c8f2a3
Compare
8c8f2a3 to
653c646
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Thanks for tackling this. Adds quite some complexity, but it really does help shorten runtimes. Few comments below. I made one suggestion directly in:
|
Merged your PR in! Thx |
danceratopz
left a comment
There was a problem hiding this comment.
There's one clean-up required that was missed in spencer-tb#24. Let me commit that real quick.
The `docc_shards` unit test never ran in CI: `fill` and the docs build skip `tests/docc` via `_add_default_ignores`, and no other job targets it, so the `compute_shards` coverage and overlap assertions went unchecked. The module itself runs via `docs-spec-parallel`, but its invariants were never asserted. Move the test to `tests/evm_tools/`, which the `spec-tools` job runs, so the assertions now execute in CI. That directory is already in `fill`'s default ignores, so the separate `tests/docc` entry is removed.
danceratopz
left a comment
There was a problem hiding this comment.
Thanks for this!
Confirmed that the last commit does actually include these tests in the spec-tools CI. All good!
🗒️ Description
Aims to improve per PR docs CI workflows.
Spec doc builds now run as four parallel docc shards over consecutive fork sets cutting
Build Spec Docsto ~4m.MkDocs social cards are now publish only, trimming
Build HTML Docsto ~5mins.Note, forward / cross-shard references are validated only by the serial default-branch build, and optionally log what PruneReferencesTransform prunes so the coverage boundary is visible in CI, more info in #3101 (comment).
🔗 Related Issues or PRs
N/A.
✅ Checklist
just static<type>(<area>):, where<type>and<area>come from an approrpriateC-<type>, respectivelyA-<area>, label. The title should match the a target squash commit message.Cute Animal Picture