Skip to content

fix(ci): skip new-commit check on manual fixture release dispatches - #3202

Merged
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/release-fixtures-devnet-dispatch
Jul 22, 2026
Merged

fix(ci): skip new-commit check on manual fixture release dispatches#3202
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:fix/release-fixtures-devnet-dispatch

Conversation

@spencer-tb

Copy link
Copy Markdown
Contributor

Description

#3100's new-commit check runs .github/scripts/check_new_commits.py from the checkout, but manual devnet releases check out inputs.branch, which can predate the script — the glamsterdam-devnet@v7.2.1 dispatch failed to spawn it. Gate the step on scheduled runs and default the run output to true for dispatches, which is all the script did for them anyway.

Related Issues or PRs

Introduced by #3100.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.39%. Comparing base (9e9bf90) to head (69fcc6e).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3202   +/-   ##
================================================
  Coverage            93.39%   93.39%           
================================================
  Files                  624      624           
  Lines                37014    37014           
  Branches              3386     3386           
================================================
  Hits                 34570    34570           
  Misses                1671     1671           
  Partials               773      773           
Flag Coverage Δ
unittests 93.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb
spencer-tb marked this pull request as ready for review July 21, 2026 12:41
@spencer-tb
spencer-tb merged commit 135af0f into ethereum:forks/amsterdam Jul 22, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants