fix: use local date for call boundary checks#194
Merged
wolovim merged 2 commits intoethereum:mainfrom Apr 2, 2026
Merged
Conversation
✅ Deploy Preview for eth-forkcast ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dionysuzx
approved these changes
Mar 30, 2026
Collaborator
dionysuzx
left a comment
dionysuzx
left a comment
There was a problem hiding this comment.
LGTM. I manually verified the timezone boundary cases this patch targets, and the updated local-date comparison behaves correctly.
wolovim
approved these changes
Apr 2, 2026
Member
wolovim
left a comment
wolovim
left a comment
There was a problem hiding this comment.
thanks for the contribution :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes date boundary logic that previously used UTC day strings (
toISOString().split('T')[0]) for "today" comparisons.Using UTC dates could shift day boundaries for users in non-UTC timezones, causing incorrect "past vs upcoming" classification near midnight local time.
Changes
src/data/calls.tssrc/utils/github.tsformatISODate(new Date())utility for consistent local date formatting.Why this is correct
Call dates in this project are compared as
YYYY-MM-DDlocal calendar dates.Using local date generation aligns "today" with user-local expectations and avoids UTC offset drift.
Validation
npm run -s lintnpm run -s buildBoth commands pass locally.