Add deployed contracts json for Reaudited Contracts#357
Add deployed contracts json for Reaudited Contracts#357pankajjagtapp wants to merge 16 commits intomasterfrom
Conversation
…; add bytecode verification script
…therFiNode, EtherFiRedemptionManager, EtherFiRestaker, EtherFiRewardsRouter, EtherFiViewer, Liquifier, and WithdrawRequestNFT
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f23c499c4a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…erification script
pankajjagtapp
force-pushed
the
pankaj/operations/add-deployed-contracts-json
branch
from
5344fa1 to
32995e5
Compare
…awRequestNFT constructor argument
…e verification process
…derly VNET limitations
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…e comments based on PR number
…eliable comment detection in coverage reports
…validation logic in WithdrawRequestNFT tests
…nal debug output for better diagnostics
📊 Forge Coverage ReportGenerated by workflow run #626 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| echo "=== DEBUG: coverage.txt size ===" | ||
| wc -l coverage.txt || echo "(file missing)" | ||
| echo "=== DEBUG: full_output.txt table lines ===" | ||
| grep -cE '^[|╭╰+]' full_output.txt || echo "0 lines match table pattern" |
There was a problem hiding this comment.
Debug output left in production CI workflow
Low Severity
Debug echo statements (=== DEBUG: ...) were added to the CI workflow but appear to be development artifacts. These add unnecessary noise to every CI run and should be removed or commented out once the coverage parsing logic is verified working.
1 participant
Note
Medium Risk
Touches mainnet upgrade/deployment scripting (including WithdrawRequestNFT constructor args and timelock salt) and CI commenting logic; while no core contract logic changes are introduced here, mistakes could impact upgrade execution and reviewer visibility of coverage.
Overview
Adds deployment and upgrade execution artifacts for the “reaudit-fixes” rollout. New
deployment/*/2026-02-02-19-56-23.jsonfiles record CREATE2 parameters and deployed implementation addresses, and new Gnosis Safe Tx Builder JSONs (reaudit-fixes-upgrade_schedule.json/_execute.json) are generated for the timelock batch upgrade.Hardens upgrade tooling and verification.
transactions-reaudit-fixes.s.solnow snapshots and verifies immutables, ownership/paused state, and initialization status across the upgrade, and writes Safe JSONs via new helpers inscript/utils/utils.sol; the timelock salt also includesblock.numberto reduce collisions.WithdrawRequestNFT’s implementation deployment/verification is updated to useWITHDRAW_REQUEST_NFT_BUYBACK_SAFE(added inDeployed.s.sol) as the constructor arg.Improves test/CI reliability on forks. The Forge coverage workflow disables ANSI color, broadens table-line parsing, adds debug output, and makes PR comment updates deterministic via a hidden marker and more robust PR number detection. Fork tests gain compatibility fixes (optional
FORK_RPC_URL, skip EIP-4788-dependent tests when unavailable, sync pending oracle report state, and minor role/actor adjustments).Written by Cursor Bugbot for commit 5d3d4f7. This will update automatically on new commits. Configure here.